lkml.org 
[lkml]   [2015]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/10] x86/intel_rdt: Implement scheduling support for Intel RDT
On Thu, 4 Jun 2015, Vikas Shivappa wrote:
> +static inline void intel_rdt_sched_in(void)
> +{
> + if (static_key_false(&rdt_enable_key))
> + __intel_rdt_sched_in();

So if the enable_key is FALSE we call the RDT stuff? I might be
missing something important, but this does not make any sense and I
have to ask how that whole stuff has been tested.

> /*
> * Protects cache_cgroups and cqm_rmid_free_lru and cqm_rmid_limbo_lru.
> @@ -403,8 +384,8 @@ static void __intel_cqm_event_count(void *info);
> static u32 intel_cqm_xchg_rmid(struct perf_event *group, u32 rmid)
> {
> struct perf_event *event;
> - struct list_head *head = &group->hw.cqm_group_entry;
> u32 old_rmid = group->hw.cqm_rmid;
> + struct list_head *head = &group->hw.cqm_group_entry;

And this change is necessary because?

Thanks,

tglx


\
 
 \ /
  Last update: 2015-06-06 12:01    [W:0.077 / U:2.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site