lkml.org 
[lkml]   [2015]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v14 15/19] perf, tools: Support long descriptions with perf list
On Fri, Jun 05, 2015 at 11:16:45AM -0700, Sukadev Bhattiprolu wrote:

SNIP

> | > hum, it should be 'v' , right?
>
> Good catch. Fixed.
> |
> | Yes that's right.
> |
> | Also BTW need to add the new option to the usage line a few lines below.
>
> How about we do this for consistency with 'perf stat'(and shows the
> long options exactly once with 'perf list -h')?
>
> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> index d0f7a18..f800927 100644
> --- a/tools/perf/builtin-list.c
> +++ b/tools/perf/builtin-list.c
> @@ -27,12 +27,12 @@ int cmd_list(int argc, const char **argv, const char *prefi
> OPT_BOOLEAN(0, "raw-dump", &raw_dump, "Dump raw events"),
> OPT_BOOLEAN('d', "desc", &desc_flag,
> "Print extra event descriptions. --no-desc to not p
> - OPT_BOOLEAN('d', "long-desc", &long_desc_flag,
> + OPT_BOOLEAN('v', "long-desc", &long_desc_flag,
> "Print longer event descriptions."),
> OPT_END()
> };
> const char * const list_usage[] = {
> - "perf list [--no-desc] [hw|sw|cache|tracepoint|pmu|event_glob]"
> + "perf list [<options>] [hw|sw|cache|tracepoint|pmu|event_glob]"
> NULL

sounds good to me, and plus the doc update ;-)

thanks,
jirka


\
 
 \ /
  Last update: 2015-06-06 09:21    [W:0.045 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site