lkml.org 
[lkml]   [2015]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 0/9] Goodix touchscreen enhancements
    Date


    > -----Original Message-----
    > From: Bastien Nocera [mailto:hadess@hadess.net]
    > Sent: 04 June, 2015 16:05
    > To: Tirdea, Irina
    > Cc: Dmitry Torokhov; linux-input@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
    > Subject: Re: [PATCH 0/9] Goodix touchscreen enhancements
    >
    > Hey Irina,
    >

    Hi Bastien,

    > On Thu, 2015-05-28 at 15:47 +0300, Irina Tirdea wrote:
    > > Add several enhancements to the Goodix touchscreen driver:
    > > - write configuration data to the device
    > > - power management support
    > > - cleanup and refactoring
    > >
    > > Irina Tirdea (9):
    > > input: goodix: fix alignment issues
    > > input: goodix: fix variable length array warning
    > > input: goodix: export id and version read from device
    > > input: goodix: add ACPI IDs for GT911 and GT9271
    > > input: goodix: reset device at init
    > > input: goodix: write configuration data to device
    > > input: goodix: add power management support
    > > input: goodix: add support for ESD
    > > input: goodix: use goodix_i2c_write_u8 instead of i2c_master_send
    >
    > Thanks a lot of that patch series. I was travelling when you sent it,
    > but I should be able to test the patch series quicker when you send a
    > v2.

    Thanks for the review and for offering to test the patches. I will send v2 asap.

    >
    > Could you please also add some references to hardware that you're
    > enabling (and presumably have been testing on) to the driver's Kconfig?
    > If the hardware is still not public, any sort of other reference would
    > be useful (Windows 8 compatible harwdare? Hardware that usually runs a
    > particular Android vendor tree?...)

    I have been using a custom setup by connecting the touchscreen directly
    to a virtual Linux environment through an USB-I2C adapter (https://diolan.com/dln-2).
    This is how I could test both ACPI and DT configurations and why the ACPI IDs I used do not
    correspond to an actual device.

    I have also done tests for the main functionality (writing config, reset, suspend/resume,
    ESD) on an Android tablet. Unfortunately the HW is not public and neither is the
    Android tree. There is an Android tree publicly available at https://01.org/android-ia,
    but it is quite different from the internal tree I am using.

    I can add a reference in Kconfig that this driver supports chip models that can be found
    on Intel tablets running Android.

    Thanks,
    Irina

    >
    > Cheers
    \
     
     \ /
      Last update: 2015-06-05 18:41    [W:9.359 / U:0.748 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site