lkml.org 
[lkml]   [2015]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/8] staging:lustre: assume a kernel build
    This whole patchset looks find to me.

    Some tips for the future.

    On Wed, Jun 03, 2015 at 04:43:20PM -0400, James Simmons wrote:
    > From: John L. Hammond <john.hammond@intel.com>
    >
    > In lnet/lnet/ and lnet/selftest/ assume a kernel build (assume that
    > __KERNEL__ is defined). Remove some common code only needed for user
    > space LNet.
    >

    > - recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES,
    > - sizeof(lnet_me_t));
    > + recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, 0, 0);

    When I'm reviewing "delete code" patches, I pretty much focus on the
    plus lines like this one. Obviously, I can figure out why we changed
    the parameters to zero but it saves me time if it's spelled out in the
    changelog.

    regards,
    dan carpenter



    \
     
     \ /
      Last update: 2015-06-05 11:21    [W:8.595 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site