lkml.org 
[lkml]   [2015]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC/PATCH 4/8] lib/kobject.c: Use strreplace
    Date
    There's probably not many slashes in kobj->name, but starting over
    when we see one feels wrong.

    Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    ---
    lib/kobject.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/lib/kobject.c b/lib/kobject.c
    index 3b841b97fccd..597d962d3d4d 100644
    --- a/lib/kobject.c
    +++ b/lib/kobject.c
    @@ -258,7 +258,6 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
    va_list vargs)
    {
    const char *old_name = kobj->name;
    - char *s;

    if (kobj->name && !fmt)
    return 0;
    @@ -270,8 +269,7 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
    }

    /* ewww... some of these buggers have '/' in the name ... */
    - while ((s = strchr(kobj->name, '/')))
    - s[0] = '!';
    + strreplace((char *)kobj->name, '/', '!');

    kfree(old_name);
    return 0;
    --
    2.1.3


    \
     
     \ /
      Last update: 2015-06-04 12:01    [W:3.424 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site