lkml.org 
[lkml]   [2015]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [f2fs-dev] [PATCH 08/12] f2fs: introduce a shrinker for mounted fs
On Tue, Jun 30, 2015 at 11:43:29AM +0800, Chao Yu wrote:
> > -----Original Message-----
> > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> > Sent: Tuesday, June 30, 2015 2:40 AM
> > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> > linux-f2fs-devel@lists.sourceforge.net
> > Cc: Jaegeuk Kim
> > Subject: [f2fs-dev] [PATCH 08/12] f2fs: introduce a shrinker for mounted fs
> >
> > This patch introduces a shrinker targeting to reduce memory footprint consumed
> > by a number of in-memory f2fs data structures.
> >
> > In addition, it newly adds:
> > - sbi->umount_mutex to avoid data races on shrinker and put_super
> > - sbi->shruinker_run_no to not revisit objects
> >
> > Noteh that the basic implementation was copied from fs/btrfs/shrinker.c
>
> Great! Good to see it's being implemented in f2fs.
>
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>
> Reviewed-by: Chao Yu <chao2.yu@samsung.com>
>
> [snip]
>
> > @@ -1406,6 +1425,9 @@ static int __init init_f2fs_fs(void)
> > err = f2fs_init_crypto();
> > if (err)
> > goto free_kset;
> > +
> > + register_shrinker(&f2fs_shrinker_info);
>
> This function can fail due to no memory, please check the return value here.

Agreed, done.

Thanks,

>
> Thanks,


\
 
 \ /
  Last update: 2015-07-01 04:01    [W:0.089 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site