lkml.org 
[lkml]   [2015]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] f2fs:Make the function check_dnode have a return type of bool
On Tue, Jun 30, 2015 at 08:56:17PM -0400, nick wrote:
>
>
> On 2015-06-30 08:50 PM, Jaegeuk Kim wrote:
> > Hi,
> >
> > On Mon, Jun 29, 2015 at 04:07:01PM -0400, Nicholas Krause wrote:
> >> This makes the function check_dnode have a return type of bool
> >> due to this particular function only ever returning either one
> >> or zero as its return value.
> >>
> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >> ---
> >> fs/f2fs/gc.c | 10 +++++-----
> >> 1 file changed, 5 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> >> index e1e7361..ebd4c6c 100644
> >> --- a/fs/f2fs/gc.c
> >> +++ b/fs/f2fs/gc.c
> >> @@ -487,7 +487,7 @@ block_t start_bidx_of_node(unsigned int node_ofs, struct f2fs_inode_info *fi)
> >> return bidx * ADDRS_PER_BLOCK + ADDRS_PER_INODE(fi);
> >> }
> >>
> >> -static int check_dnode(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
> >> +static bool check_dnode(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
> >
> > Then, what about bool is_data_alive() ?
> >
> > Thanks,
> >
> There is no function of this name in my searching with either lxr or cscope.
> Either my tools aren't finding it or the function you are requesting I make
> bool has been removed.
> Nick

I meant;
if you want to change the return type as a bool type, what about changing its
function name too? (e.g., is_data_alive())


\
 
 \ /
  Last update: 2015-07-01 03:21    [W:0.033 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site