lkml.org 
[lkml]   [2015]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] schedstat: Expose /proc/pid/schedstat if CONFIG_SCHED_INFO is set
On 2015/06/30 11:25AM, Srikar Dronamraju wrote:
> * Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> [2015-06-25 23:53:38]:
>
> > /*
> > * Provides /proc/PID/schedstat
> > */
> > static int proc_pid_schedstat(struct seq_file *m, struct pid_namespace *ns,
> > struct pid *pid, struct task_struct *task)
> > {
> > - seq_printf(m, "%llu %llu %lu\n",
> > + if (unlikely(!sched_info_on()))
> > + seq_printf(m, "0 0 0\n");
> > + else
> > + seq_printf(m, "%llu %lld %ld\n",
>
> Should the above be seq_printf(m, "%llu %llu %lu\n", ?

Yikes! Nice catch, thanks! This looks to be left over from my tests with
returning -1. Fixed patch on the way...

Regards,
Naveen



\
 
 \ /
  Last update: 2015-06-30 08:21    [W:0.062 / U:1.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site