Messages in this thread | | | Date | Tue, 30 Jun 2015 11:46:49 +0530 | From | "Naveen N. Rao" <> | Subject | Re: [PATCH v2 2/2] schedstat: Expose /proc/pid/schedstat if CONFIG_SCHED_INFO is set |
| |
On 2015/06/30 11:25AM, Srikar Dronamraju wrote: > * Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> [2015-06-25 23:53:38]: > > > /* > > * Provides /proc/PID/schedstat > > */ > > static int proc_pid_schedstat(struct seq_file *m, struct pid_namespace *ns, > > struct pid *pid, struct task_struct *task) > > { > > - seq_printf(m, "%llu %llu %lu\n", > > + if (unlikely(!sched_info_on())) > > + seq_printf(m, "0 0 0\n"); > > + else > > + seq_printf(m, "%llu %lld %ld\n", > > Should the above be seq_printf(m, "%llu %llu %lu\n", ?
Yikes! Nice catch, thanks! This looks to be left over from my tests with returning -1. Fixed patch on the way...
Regards, Naveen
| |