lkml.org 
[lkml]   [2015]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio: omap: prevent module from being unloaded while in use
On Fri, Jun 26, 2015 at 12:13 AM, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:
> OMAP GPIO driver allowed to be built as loadable module, but it
> doesn't set owner field in GPIO chip structure. As result,
> module_get/put() API is not working and it's possible to unload
> OMAP driver while in use:
>
> omap_gpio 48051000.gpio: REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED
>
> Hence, add missing configuration.

Isn't this also fixed by your other patch "gpiolib: assign chip owner
to dev->driver->owner if not set"?

Nevertheless,

Acked-by: Alexandre Courbot <acourbot@nvidia.com>

For inclusion into -rc if the other patch is for the next cycle.

>
> Cc: Tony Lindgren <tony@atomide.com>
> Fixes: cac089f9026e ('gpio: omap: Allow building as a loadable module')
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> Hi Linus,
>
> Seems this one is for 4.2-rc.
>
> drivers/gpio/gpio-omap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index a0ad803..61a731f 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1187,6 +1187,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
> bank->irq = res->start;
> bank->dev = dev;
> bank->chip.dev = dev;
> + bank->chip.owner = THIS_MODULE;
> bank->dbck_flag = pdata->dbck_flag;
> bank->stride = pdata->bank_stride;
> bank->width = pdata->bank_width;
> --
> 2.4.4
>


\
 
 \ /
  Last update: 2015-06-30 16:21    [W:0.047 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site