lkml.org 
[lkml]   [2015]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] SCSI-aic94xx: Deletion of an unnecessary check before the function call "kfree"
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Thu, 20 Nov 2014 23:18:56 +0100
    >
    > The kfree() function tests whether its argument is NULL and then
    > returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/scsi/aic94xx/aic94xx_init.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
    > index c56741f..0bfdcba 100644
    > --- a/drivers/scsi/aic94xx/aic94xx_init.c
    > +++ b/drivers/scsi/aic94xx/aic94xx_init.c
    > @@ -597,8 +597,7 @@ static void asd_destroy_ha_caches(struct asd_ha_struct *asd_ha)
    > if (asd_ha->hw_prof.scb_ext)
    > asd_free_coherent(asd_ha, asd_ha->hw_prof.scb_ext);
    >
    > - if (asd_ha->hw_prof.ddb_bitmap)
    > - kfree(asd_ha->hw_prof.ddb_bitmap);
    > + kfree(asd_ha->hw_prof.ddb_bitmap);
    > asd_ha->hw_prof.ddb_bitmap = NULL;
    >
    > for (i = 0; i < ASD_MAX_PHYS; i++) {
    >

    How are the chances to integrate this update suggestion
    into another source code repository?

    Regards,
    Markus


    \
     
     \ /
      Last update: 2015-06-30 15:01    [W:4.016 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site