lkml.org 
[lkml]   [2015]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC 1/1] perf,tool: partial callgrap and time support
On Sun, Jun 28, 2015 at 01:47:21PM -0400, kan.liang@intel.com wrote:

SNIP

> Signed-off-by: Kan Liang <kan.liang@intel.com>
> ---
> tools/perf/Documentation/perf-record.txt | 13 ++++++++
> tools/perf/builtin-record.c | 7 ++--
> tools/perf/perf.h | 2 ++
> tools/perf/util/evsel.c | 55 ++++++++++++++++++++++++++++++--
> tools/perf/util/parse-events.c | 33 +++++++++++++++++++
> tools/perf/util/parse-events.h | 3 ++
> tools/perf/util/parse-events.l | 3 ++
> tools/perf/util/parse-options.c | 2 ++
> tools/perf/util/parse-options.h | 4 +++
> 9 files changed, 116 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> index 9b9d9d0..f945b01 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -45,6 +45,19 @@ OPTIONS
> param1 and param2 are defined as formats for the PMU in:
> /sys/bus/event_sources/devices/<pmu>/format/*
>
> + There are also some params which are not defined in .../<pmu>/format/*.
> + These params can be used to set event defaults.
> + Here is a list of the params.
> + - 'period': Set event sampling period
> + - 'callgraph': Disable/enable callgraph. Acceptable values are
> + 1 for FP mode, 2 for dwarf mode, 3 for LBR mode,
> + 0 for disabling callgraph.

why dont use strings like 'fp,dwarf,lbr' to identify callchains?
you'd have:

'{cpu/cpu-cycles,callgraph=fp,time=1,period=100000/,

also you dont need to assign 1 to time, it's the default, so this is equal:

'{cpu/cpu-cycles,callgraph=fp,time,period=100000/,

come to that, 'fp' could be default for callgraph, like:

'{cpu/cpu-cycles,callgraph,time,period=100000/,

we already have string terms translation support
in pmu_config_term.. but I guess this is not pmu specific
and can stay in config_term

also please add appropriate tests to tests/parse-events.c

thanks,
jirka


\
 
 \ /
  Last update: 2015-06-30 14:41    [W:0.031 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site