Messages in this thread | | | Date | Tue, 30 Jun 2015 08:58:07 +0200 | From | Wim Van Sebroeck <> | Subject | Re: [PATCH v2] watchdog: omap_wdt: early_enable module parameter |
| |
Hi Paul,
> On Thu, Jun 25, 2015 at 9:46 AM, Guenter Roeck <linux@roeck-us.net> wrote: > > On 06/25/2015 03:21 AM, poeschel@lemonage.de wrote: > >> > >> From: Lars Poeschel <poeschel@lemonage.de> > >> > >> Add a early_enable module parameter to the omap_wdt that starts the > >> watchdog on module insertion. The default value is 0 which does not > >> start the watchdog - which also does not change the behavior if the > >> parameter is not given. > >> > >> Signed-off-by: Lars Poeschel <poeschel@lemonage.de> > > > > > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > In case the info hasn't looped back around yet, this breaks the > omap builds in linux-next: > > drivers/watchdog/omap_wdt.c:288:18: error: 'omap_wdt' undeclared > (first use in this function) > > (Not sure how this could have ever worked as-is.) > > http://kisskb.ellerman.id.au/kisskb/buildresult/12452335/ > > I see a patch has already been posted to arm-kernel but not > Cc'd to all originally involved so figured I'd mention it.
It's fixed. The reason why we din't catch it was because of interference with 'watchdog: omap: put struct watchdog_device into driver data'.
Kind regards, Wim.
| |