lkml.org 
[lkml]   [2015]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver
On 06/01/2015 11:05 PM, fu.wei@linaro.org wrote:
> + if (wdd->pretimeout)
> + /* The pretimeout is valid, go panic */
> + panic("SBSA Watchdog pre-timeout");

The problem with this is that WS1 will still occur. So a few seconds
after the panic() call, the hardware will reset. There won't be any
time to debug or log anything.

> + /* We don't use pretimeout, trigger WS1 now*/
> + sbsa_gwdt_set_wcv(wdd, 0);

Are you sure this will work? This will set WCV to 0, which means it
the WS1 reset won't happen until the timestamp counter wraps around to
0. That could be a very long time from now.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.


\
 
 \ /
  Last update: 2015-06-03 20:41    [W:0.179 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site