lkml.org 
[lkml]   [2015]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 1/2] tracing: Prefer kcalloc over kzalloc with multiply
    Date
    On Tue, Jun 2, 2015 at 5:15 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
    > On Tue, 2 Jun 2015 16:26:28 +0300
    > Gil Fruchter <gilf@ezchip.com> wrote:
    >
    >> fix checkpatch warning for using kzalloc with multiply:
    >> WARNING: Prefer kcalloc over kzalloc with multiply
    >> + iter->buffer_iter = kzalloc(sizeof(*iter->buffer_iter)
    >> * num_possible_cpus(),
    >
    > I'm not against applying this patch, but "fix checkpatch warning" is never rational for a change.
    >
    > This should say something like, "Use kcalloc for allocating an array instead of a simple multiplier with kzalloc, as that is what kcalloc is used for."
    >
    > In other words, if checkpatch found something that should be change, have the change log tell us why it should be changed. You can than add a "Found with checkpatch" to give checkpatch the credit.
    >
    > -- Steve
    >

    Thanks for the input Steve.
    I will create a v2 with an appropriate explanation for this change.

    Can I add a Reviewed-by tag by you?

    Gil


    \
     
     \ /
      Last update: 2015-06-03 14:21    [W:3.392 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site