lkml.org 
[lkml]   [2015]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele"
    On Fri, Jun 26, 2015 at 11:15:31AM +0200, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Fri, 26 Jun 2015 11:05:41 +0200
    >
    > The xfs_qm_dqrele() function tests whether its argument is NULL and
    > then returns immediately.

    True.

    > Thus the test around the call is not needed.

    But wrong.

    xfs_dqrele_inode() gets called on every inode in the inode cache,
    and this change results in a cacheline in every inode being dirtied
    even if they don't have dquots attached. Given the inode cache can
    hold tens to hundreds of millions of inodes on large machines, we
    don't want to dirty any cachelines we don't need to while walking
    the inode cache and releasing dquots...

    Cheers,

    Dave.
    --
    Dave Chinner
    david@fromorbit.com


    \
     
     \ /
      Last update: 2015-06-30 00:01    [W:4.044 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site