lkml.org 
[lkml]   [2015]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] keystone: adds cpu_die implementation


    On 6/29/15 11:43 AM, Vitaly Andrianov wrote:
    >
    >
    > On 06/29/2015 01:52 PM, Mark Rutland wrote:
    >> On Mon, Jun 29, 2015 at 06:52:32PM +0100, Vitaly Andrianov wrote:
    >>> This commit add cpu_die implementation
    >>>
    >>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
    >>> ---
    >>>
    >>> The discussion of the "keystone: psci: adds cpu_die implementation"
    >>> commit
    >>> shows that if PCSI is enabled platform code doesn't need that
    >>> implementation
    >>> at all. Having PSCI commands in DTB should be sufficient. Unfortunately
    >>> Keystone with LPAE enable requires some additional development.
    >>
    >> I don't follow.
    >>
    >> What do you need to implement for LPAE?
    > Hi Mark,
    >
    > The Keystone platform needs to set ttbr1 when it boots secondary core.
    > It is done in the keystone_smp_secondary_initmem(), which is
    > .smp_secondary_init member of the keystone_smp_ops. I couldn't find a
    > way how I can add similar function to psci_smp_ops.
    >
    > Do you have any idea?
    >
    >>
    >> Why not implement that rather than adding more platform code that you'll
    >> likely want to remove later anyway?
    >
    > If I can solve the above problem, I will not add this code.
    >
    This problem is already solved. :-)

    After [1], there is no longer need to fiddle with TTBR1 setup
    for secondary bringup. I believe its already in RMK's queue and it
    should show up in linus's tree after 4.2 merge window.


    Regards,
    Santosh

    [1] http://www.spinics.net/lists/arm-kernel/msg416129.html



    \
     
     \ /
      Last update: 2015-06-29 23:41    [W:2.392 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site