lkml.org 
[lkml]   [2015]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] PCI-iproc: Delete unnecessary checks before two function calls
    Hi Markus,

    On 6/28/2015 7:52 AM, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sun, 28 Jun 2015 16:42:04 +0200
    >
    > The functions phy_exit() and phy_power_off() test whether their argument
    > is NULL and then return immediately.
    > Thus the test around the calls is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/pci/host/pcie-iproc.c | 7 ++-----
    > 1 file changed, 2 insertions(+), 5 deletions(-)
    >
    > diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c
    > index d77481e..f875821 100644
    > --- a/drivers/pci/host/pcie-iproc.c
    > +++ b/drivers/pci/host/pcie-iproc.c
    > @@ -239,12 +239,9 @@ err_rm_root_bus:
    > pci_remove_root_bus(bus);
    >
    > err_power_off_phy:
    > - if (pcie->phy)
    > - phy_power_off(pcie->phy);
    > + phy_power_off(pcie->phy);
    > err_exit_phy:
    > - if (pcie->phy)
    > - phy_exit(pcie->phy);
    > -
    > + phy_exit(pcie->phy);
    > return ret;
    > }
    > EXPORT_SYMBOL(iproc_pcie_setup);
    >

    Thanks for catching this. Could you please help to make similar changes
    to both phy_init and phy_power_on calls in the driver, to make it
    consistent?

    Thanks,

    Ray


    \
     
     \ /
      Last update: 2015-06-29 19:01    [W:4.018 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site