lkml.org 
[lkml]   [2015]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]: MUX n_gsm debug print improvements
On Mon, Jun 29, 2015 at 05:54:58PM +0200, Gwenn Bourrée wrote:
>
> Dear kernel tty maintainers,
>
> Please review the following patch:
>
> From 0ac5da0a4653f43ce4b0761a2be8073185c549bb Mon Sep 17 00:00:00 2001
> From: Gwenn Bourree <gwenn.bourree@intel.com>
> Date: Mon, 29 Jun 2015 16:09:06 +0200
> Subject: [PATCH] Add Debug define
>
> Improve the debug print out and make be clearest
>
> Signed-off-by: Gwenn Bourree <gwenn.bourree@intel.com>
> Signed-off-by: Mustapha Ben Zoubeir <mustaphax.ben.zoubeir@intel.com>
> Signed-off-by: Nicolas LOUIS <nicolasx.louis@intel.com>
> Reviewed-by: Ravindran, Arun <arun.ravindran@intel.com
>
> ---
> drivers/tty/n_gsm.c | 49
> ++++++++++++++++++++++++++++---------------------
> 1 file changed, 28 insertions(+), 21 deletions(-)

Also, your patch is line-wrapped and also base64 encoded, making it
impossible to edit, or apply. Please fix up your email client to use
the proper configuration, as I'm sure Intel has documentation for how to
do.

In fact, it has documentation for how to do all of this, why aren't you
following it?

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-06-29 18:21    [W:0.077 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site