Messages in this thread | | | Date | Mon, 29 Jun 2015 17:47:49 +0200 | Subject | Re: [PATCH 3/3] printk: implement support for extended console drivers | From | Geert Uytterhoeven <> |
| |
Hi Tejun,
On Mon, Jun 29, 2015 at 5:28 PM, Tejun Heo <tj@kernel.org> wrote: > On Mon, Jun 29, 2015 at 11:20:41AM +0200, Geert Uytterhoeven wrote: >> On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo <tj@kernel.org> wrote: >> > --- a/kernel/printk/printk.c >> > +++ b/kernel/printk/printk.c >> >> > @@ -2196,6 +2227,7 @@ out: >> > */ >> > void console_unlock(void) >> > { >> > + static char ext_text[CONSOLE_EXT_LOG_MAX]; >> >> Can you please >> a) make this feature optional, > > netconsole itself is optional & modular. I'm not sure making further > splits is called for, especially given the use cases.
It could be a hidden option, selected by its users (e.g. netconsole).
>> b) (de)allocate this buffer dynamically when the first/last console with >> CON_EXTENDED set is (un)registered? > > But yeah, making the buffer allocated on demand should be simple > enough. Will get to it.
Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |