lkml.org 
[lkml]   [2015]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] drm/amdgpu: Delete an unnecessary check before the function call "kfree"
    From
    On Sun, Jun 28, 2015 at 4:45 AM, SF Markus Elfring
    <elfring@users.sourceforge.net> wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sun, 28 Jun 2015 10:27:35 +0200
    >
    > The kfree() function tests whether its argument is NULL and then
    > returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

    I already have the same patch from Maninder Singh.

    Thanks!

    Alex

    > ---
    > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    > index fec487d..a85cd08 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    > @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
    > amdgpu_fence_driver_fini(adev);
    > amdgpu_fbdev_fini(adev);
    > r = amdgpu_fini(adev);
    > - if (adev->ip_block_enabled)
    > - kfree(adev->ip_block_enabled);
    > + kfree(adev->ip_block_enabled);
    > adev->ip_block_enabled = NULL;
    > adev->accel_working = false;
    > /* free i2c buses */
    > --
    > 2.4.4
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > http://lists.freedesktop.org/mailman/listinfo/dri-devel


    \
     
     \ /
      Last update: 2015-06-29 18:01    [W:6.134 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site