Messages in this thread | | | Subject | Re: [PATCH perf/core] perf tools: Add missing break for PERF_RECORD_ITRACE_START | From | Joe Perches <> | Date | Mon, 29 Jun 2015 04:23:29 -0700 |
| |
On Mon, 2015-06-29 at 13:12 +0200, Jiri Olsa wrote: > Missing switch break since introduction of new event: > c4937a91ea56 perf tools: handle PERF_RECORD_LOST_SAMPLES [] > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c [] > @@ -1448,7 +1448,7 @@ int machine__process_event(struct machine *machine, union perf_event *event, > case PERF_RECORD_AUX: > ret = machine__process_aux_event(machine, event); break; > case PERF_RECORD_ITRACE_START: > - ret = machine__process_itrace_start_event(machine, event); > + ret = machine__process_itrace_start_event(machine, event); break; > case PERF_RECORD_LOST_SAMPLES: > ret = machine__process_lost_samples_event(machine, event, sample); break; > break;
trivia: There's a duplicate/unreachable break; on the PERF_RECORD_LOST_SAMPLES case
| |