lkml.org 
[lkml]   [2015]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] staging: comedi: adl_pci9118: Delete an unnecessary check before the function call "pci_dev_put"
    On 27/06/15 13:10, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sat, 27 Jun 2015 13:50:43 +0200
    >
    > The pci_dev_put() function tests whether its argument is NULL and then
    > returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
    > index fb3043d..19b5806 100644
    > --- a/drivers/staging/comedi/drivers/adl_pci9118.c
    > +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
    > @@ -1717,8 +1717,7 @@ static void pci9118_detach(struct comedi_device *dev)
    > pci9118_reset(dev);
    > comedi_pci_detach(dev);
    > pci9118_free_dma(dev);
    > - if (pcidev)
    > - pci_dev_put(pcidev);
    > + pci_dev_put(pcidev);
    > }
    >
    > static struct comedi_driver adl_pci9118_driver = {
    >

    The same patch was posted independently (and earlier) by Maninder Singh,
    but I think we concluded that the code was more understandable without
    this change, as the test within pci_dev_put() is more of a safety net.

    --
    -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
    -=( Web: http://www.mev.co.uk/ )=-


    \
     
     \ /
      Last update: 2015-06-29 12:21    [W:4.082 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site