lkml.org 
[lkml]   [2015]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/22] iommu: Propagate error in add_iommu_group
    Hello Heiko,

    On Mon, Jun 29, 2015 at 11:28:40AM +0200, Heiko Stübner wrote:
    > The Rockchip iommu uses bus_set_ops to set its iommu-ops for the platform
    > bus and currently returns -ENODEV if it encounters a platform_devices that
    > does not have an iommu. As add_iommu_group ignored these returns
    > till now this worked, but of course starts to fail now.
    >
    > All two invocations of the add_device callback ignored (or still ignore) the
    > return value so I've come with the following small patch to fix the breakage
    > that now exists in the 4.2 tree.
    >
    > There is probably a better solution possible in the longer term, likely
    > similar to what Samsung does, but I'm not sure yet how this would work
    > with our drm device that needs an iommu mapping without having an
    > iommu (the iommus being attached to the crtc-components).

    Yes, this issue was already reported from the Exynos side. I have a fix
    which just ignores -ENODEV as the return value for now. This fixes
    Exynos, and should fix Rockchip (and some other IOMMU drivers) too.


    Joerg



    \
     
     \ /
      Last update: 2015-06-29 11:41    [W:3.375 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site