Messages in this thread | | | Date | Fri, 26 Jun 2015 02:11:03 +0300 | From | Ville Syrjälä <> | Subject | Re: [PATCH v5 1/3] video: fbdev: atyfb: clarify ioremap() base and length used |
| |
On Thu, Jun 25, 2015 at 04:06:45PM -0700, Luis R. Rodriguez wrote: > On Thu, Jun 25, 2015 at 4:04 PM, Ville Syrjälä <syrjala@sci.fi> wrote: > > it doesn't hurt too much > > since smem_len gets overwritten later in aty_init(). > > That's the idea, we set it with a default as it will be overwritten > later anyway.
Maybe toss in a comment? Otherwise it's a bit dishonest and might give someone the impression that all PCI cards really have 8MB of memory.
-- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/
| |