Messages in this thread | | | Date | Thu, 25 Jun 2015 22:43:42 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/1] mm: move ->mremap() from file_operations to vm_operations_struct |
| |
On 06/24, Kirill A. Shutemov wrote: > > On Wed, Jun 24, 2015 at 05:49:14PM +0200, Oleg Nesterov wrote: > > > > Wait... Documentation/filesystems/Locking doesn't mention > > ->mremap() at all. > > > > So you actually ask me to add the new documentation? ;) > > I tried ;)
Understand ;) but I failed to do this. Serisouly, I simply don't know what can I add into this (outadted anyway) section except "called when move_page_tables() targets this vma".
> > I tried to make the minimal change before ->mremap() finds another > > user in file_operations. I thinks it needs more arguments, at least > > new_addr and new_len, otherwise it is not easy to document it. The > > same for f_op->mremap() of course. > > > > Currently this does not matter, the only user is aio.c and > > VM_DONTEXPAND means that it is not mergeable, so mremap() always > > creates the new vma. > > > > Hmm. Can't we do this change and add the documentation later? > > I'm fine with that.
OK, so I am sending v2 with the only change: rename aio_ring_remap to aio_ring_mremap as you suggested.
Oleg.
| |