Messages in this thread | | | Date | Thu, 25 Jun 2015 16:57:59 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH v5 1/2] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable |
| |
On Thu, 25 Jun 2015, Vitaly Kuznetsov wrote:
> Loaded Hyper-V module will use these functions to disable CPU hotplug > under certain circumstances. Convert cpu_hotplug_disabled to a counter > (protected by cpu_add_remove_lock) to support e.g. disable -> disable -> > enable call sequences.
This changelog including the subject line still sucks.
Q: How is the counter change related subject line? A: Not at all.
Q: Why do we need to change this to a counter? A: Because
Q: What problem is being solved? A: Dunno
Q: Why do we need the export? A: HyperV having certain circumstances
Summary: The changelog is useless
The patch wants to be split in two parts:
1) Make the counter change and explain why the current mode is not sufficient and what kind of problem can be solved
2) Export the functions with a proper explanation why.
Thanks,
tglx
| |