lkml.org 
[lkml]   [2015]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/2] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable
On Thu, 25 Jun 2015, Vitaly Kuznetsov wrote:

> Loaded Hyper-V module will use these functions to disable CPU hotplug
> under certain circumstances. Convert cpu_hotplug_disabled to a counter
> (protected by cpu_add_remove_lock) to support e.g. disable -> disable ->
> enable call sequences.

This changelog including the subject line still sucks.

Q: How is the counter change related subject line?
A: Not at all.

Q: Why do we need to change this to a counter?
A: Because

Q: What problem is being solved?
A: Dunno

Q: Why do we need the export?
A: HyperV having certain circumstances

Summary: The changelog is useless

The patch wants to be split in two parts:

1) Make the counter change and explain why the current mode is not
sufficient and what kind of problem can be solved

2) Export the functions with a proper explanation why.

Thanks,

tglx




\
 
 \ /
  Last update: 2015-06-25 17:21    [W:0.025 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site