lkml.org 
[lkml]   [2015]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 35/71] net: dp83640: fix broken calibration routine.
    Date
    3.16.7-ckt14 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Richard Cochran <richardcochran@gmail.com>

    commit 397a253af5031de4a4612210055935309af4472c upstream.

    Currently, the calibration function that corrects the initial offsets
    among multiple devices only works the first time. If the function is
    called more than once, the calibration fails and bogus offsets will be
    programmed into the devices.

    In a well hidden spot, the device documentation tells that trigger indexes
    0 and 1 are special in allowing the TRIG_IF_LATE flag to actually work.

    This patch fixes the issue by using one of the special triggers during the
    recalibration method.

    Signed-off-by: Richard Cochran <richardcochran@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/net/phy/dp83640.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
    index 9408157a246c..4452bbe97a1d 100644
    --- a/drivers/net/phy/dp83640.c
    +++ b/drivers/net/phy/dp83640.c
    @@ -46,7 +46,7 @@
    #define PSF_TX 0x1000
    #define EXT_EVENT 1
    #define CAL_EVENT 7
    -#define CAL_TRIGGER 7
    +#define CAL_TRIGGER 1
    #define PER_TRIGGER 6
    #define DP83640_N_PINS 12


    \
     
     \ /
      Last update: 2015-06-25 12:41    [W:4.336 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site