lkml.org 
[lkml]   [2015]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Use of pinctrl-single for external device over I2C


    On Wednesday 24 June 2015 07:03 PM, Tony Lindgren wrote:
    > * Vaibhav Hiremath <vaibhav.hiremath@linaro.org> [150624 05:06]:
    >> On Tuesday 23 June 2015 04:25 PM, Vaibhav Hiremath wrote:
    >>>
    >>> /*
    >>> * REVISIT: Reads and writes could eventually use regmap or something
    >>> * generic. But at least on omaps, some mux registers are performance
    >>> * critical as they may need to be remuxed every time before and after
    >>> * idle. Adding tests for register access width for every read and
    >>> * write like regmap is doing is not desired, and caching the registers
    >>> * does not help in this case.
    >>> */
    >>>
    >>>
    >>> Should be not have flag for this and use regmap_ variants? If we
    >>> implement flag based approach then same driver can be reused for pinmux
    >>> configuration of external device.
    >
    > Nothing stopping you from adding regmap support to it. It just needs
    > to be made optional as the users so far don't need it.
    >

    Yeah, absolutely.

    Thinking more on this,


    I do not like this, as this is not HW feature, so DT may not be right
    approach.


    So I will dig more from either runtime or Compile time option to use
    regmap_ Vs raw read/writes.


    Thanks,
    Vaibhav



    \
     
     \ /
      Last update: 2015-06-24 19:41    [W:4.375 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site