lkml.org 
[lkml]   [2015]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 04/10] Drivers: hv: vmbus: add special kexec handler
On Tue, Jun 23, 2015 at 06:28:36PM +0200, Vitaly Kuznetsov wrote:
> Olaf Hering <olaf@aepfle.de> writes:
>
> > On Thu, Jun 04, K. Y. Srinivasan wrote:
> >
> >> +++ b/arch/x86/kernel/cpu/mshyperv.c
> >> @@ -18,6 +18,9 @@
> >> #include <linux/efi.h>
> >> #include <linux/interrupt.h>
> >> #include <linux/irq.h>
> >> +#ifdef CONFIG_KEXEC
> >> +#include <linux/kexec.h>
> >> +#endif
> >
> > Is this #ifdef required?
> >
>
> No, it's not, but other parts of the same patch do (e.g. there is no
> kexec_in_progress without CONFIG_KEXEC). We can probably omit #ifdef
> here but I'm not sure it makes sense.

No #ifdef should be in a .c file if at all possible, so please remove
them all if you can. If not, then work to fix up the .h file properly
so that you can.

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-06-24 05:21    [W:0.040 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site