lkml.org 
[lkml]   [2015]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] Added tables (i2c/platform)_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name.


On Tue, 23 Jun 2015, Daniel Granat wrote:

> Signed-off-by: Daniel Granat <d.granat@samsung.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
> scripts/coccinelle/misc/of_table.cocci | 33 ++++++++++++++++++++++++++++-----
> 1 file changed, 28 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/coccinelle/misc/of_table.cocci b/scripts/coccinelle/misc/of_table.cocci
> index 3c93404..2294915 100644
> --- a/scripts/coccinelle/misc/of_table.cocci
> +++ b/scripts/coccinelle/misc/of_table.cocci
> @@ -1,6 +1,6 @@
> -/// Make sure of_device_id tables are NULL terminated
> +/// Make sure (of/i2c/platform)_device_id tables are NULL terminated
> //
> -// Keywords: of_table
> +// Keywords: of_table i2c_table platform_table
> // Confidence: Medium
> // Options: --include-headers
>
> @@ -13,18 +13,26 @@ virtual report
> identifier var, arr;
> expression E;
> @@
> -struct of_device_id arr[] = {
> +(
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
> ...,
> {
> .var = E,
> * }
> };
> +|
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
> + ...,
> +* { ..., E, ... },
> +};
> +)
>
> @depends on patch@
> identifier var, arr;
> expression E;
> @@
> -struct of_device_id arr[] = {
> +(
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
> ...,
> {
> .var = E,
> @@ -32,19 +40,34 @@ struct of_device_id arr[] = {
> + },
> + { }
> };
> +|
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
> + ...,
> + { ..., E, ... },
> ++ { },
> +};
> +)
>
> @r depends on org || report@
> position p1;
> identifier var, arr;
> expression E;
> @@
> -struct of_device_id arr[] = {
> +(
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
> ...,
> {
> .var = E,
> }
> @p1
> };
> +|
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
> + ...,
> + { ..., E, ... }
> + @p1
> +};
> +)
>
> @script:python depends on org@
> p1 << r.p1;
> --
> 1.9.1
>
>


\
 
 \ /
  Last update: 2015-06-23 14:41    [W:0.083 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site