Messages in this thread | | | Subject | Re: [PATCH v2] hexdump: fix for non-aligned buffers | From | Joe Perches <> | Date | Sun, 21 Jun 2015 21:58:03 -0700 |
| |
On Mon, 2015-06-22 at 01:42 +0200, =?UTF-8?q?Horacio=20Mijail=20Ant=C3=B3n=20Quiles?= wrote: > An hexdump with a buf not aligned to the groupsize causes > non-naturally-aligned memory accesses. This was causing a kernel panic on > the processor BlackFin BF527, when such an unaligned buffer was fed by the > function ubifs_scanned_corruption in fs/ubifs/scan.c . [] > diff --git a/lib/hexdump.c b/lib/hexdump.c [] > @@ -123,6 +123,11 @@ int hex_dump_to_buffer(const void *buf, size_t len, int rowsize, int groupsize, > groupsize = 1; > if ((len % groupsize) != 0) /* no mixed size output */ > groupsize = 1; > + > + /* fall back to 1-byte groups if buf is not aligned to groupsize*/
Please add a space before the "*/"
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
| |