Messages in this thread | | | From | Noam Camus <> | Subject | RE: [PATCH v5] NET: Add ezchip ethernet driver | Date | Mon, 22 Jun 2015 14:52:48 +0000 |
| |
From: David Miller [mailto:davem@davemloft.net] Sent: Sunday, June 21, 2015 7:22 PM
> This builds with several warnings and also doesn't compile. > > drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_read_rx_fifo’: > drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_send_frame’: > drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] Once I start to use newer GCC (5.1.1) I get those as well. My previous GCC (4.8) did not report them.
> drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_poll_controller’: > drivers/net/ethernet/ezchip/nps_enet.c:535:2: error: implicit declaration of function ‘nps_enet_board_irq_handler’ [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors My configuration lacked the CONFIG_NET_POLL_CONTROLLER this is why I missed this typo caused due to renaming. I added CONFIG_NETCONSOLE to my configuration, now GCC report this error as well.
> I do not even see where npe_enet_board_irq_handler could possible be defined. It was renamed: nps_enet_board_irq_handler -> nps_enet_irq_handler (I removed the _board).
> It is quite infuriating to receive a patch like this which is claimed to be complete and ready to be applied to my tree, yet it is very clearly not. My sincerest apologies for any problem I have made. I will send another version that will be worth applying to your tree.
Noam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
| |