Messages in this thread | | | From | Robert Jarzmik <> | Subject | Re: [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions | Date | Sun, 21 Jun 2015 20:05:06 +0200 |
| |
Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
> On Sat, 20 Jun 2015, Robert Jarzmik wrote: > >> Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes: >> >> >> +static void pxa_camera_dma_irq(struct pxa_camera_dev *pcdev, >> >> + enum pxa_camera_active_dma act_dma); >> >> + >> >> +static void pxa_camera_dma_irq_y(void *data) >> > >> > Wait, how is this patch trivial? You change pxa_camera_dma_irq_?() >> > prototypes, which are used as PXA DMA callbacks. Does this mean, that >> > either before or after this patch compilation is broken? >> >> Jeez you're right. >> So I can either fold that with patch 4, or try to rework it somehow ... > > How about letting that patch do exactly what it says it does? Just move > functions up in the file if you need them there, without changing them, > and only change them when it's needed? Deal, for next iteration.
Cheers.
-- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
| |