Messages in this thread | | | Date | Sun, 21 Jun 2015 09:31:02 -0700 | Subject | Re: [PATCH 03/15] nd_btt: atomic sector updates | From | Dan Williams <> |
| |
On Sun, Jun 21, 2015 at 3:03 AM, Christoph Hellwig <hch@lst.de> wrote: >> +config ND_MAX_REGIONS >> + int "Maximum number of regions supported by the sub-system" >> + default 64 >> + ---help--- >> + A 'region' corresponds to an individual DIMM or an interleave >> + set of DIMMs. A typical maximally configured system may have >> + up to 32 DIMMs. >> + >> + Leave the default of 64 if you are unsure. > > Having static limits in Kconfig is a bad idea. What prevents you > from handling any (reasonable) number dynamically?
Hmm, yes, this was a bad holdover from before we were using percpu definitions for the lane locks. Now that it's converted we can kill the static definition of nd_percpu_lane and just do an alloc_percpu() for each region dynamically. Fixed in v2 and passing the test suite. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
| |