Messages in this thread | | | Date | Wed, 03 Jun 2015 08:55:55 +0900 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu |
| |
On 02.06.2015 22:38, Andreas Färber wrote: > Am 02.06.2015 um 22:02 schrieb Krzysztof Kozlowski: >> W dniu 16.03.2015 o 07:00, Andreas Färber pisze: >>> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com> >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> --- >>> v2 -> v3: Unchanged >>> >>> v1 -> v2: >>> * Filled in Sob from Hakjoo Kim >>> >>> arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >> >> What is the rationale behind doing this in separate patch, not as part >> of 2/5? You can just add new board DTS with all of its features at once, >> but maybe I am missing something? > > This patch depends on the pinctrl driver, 2/5 on nothing. > > By keeping it a separate patch it was intended to go in more quickly > (clear fail there ;)) and it's easier to review the actual changes - > squashing is always easier than picking apart.
OK, I'm fine with it.
The patch looks good: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Can you resend everything with the change in chosen/console?
Best regards, Krzysztof
| |