lkml.org 
[lkml]   [2015]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 0/2] mapping_gfp_mask from the page fault path
On Mon,  1 Jun 2015 15:00:01 +0200 Michal Hocko <mhocko@suse.cz> wrote:

> I somehow forgot about these patches. The previous version was
> posted here: http://marc.info/?l=linux-mm&m=142668784122763&w=2. The
> first attempt was broken but even when fixed it seems like ignoring
> mapping_gfp_mask in page_cache_read is too fragile because
> filesystems might use locks in their filemap_fault handlers
> which could trigger recursion problems as pointed out by Dave
> http://marc.info/?l=linux-mm&m=142682332032293&w=2.
>
> The first patch should be straightforward fix to obey mapping_gfp_mask
> when allocating for mapping. It can be applied even without the second
> one.

I'm not so sure about that. If only [1/2] is applied then those
filesystems which are setting mapping_gfp_mask to GFP_NOFS will now
actually start using GFP_NOFS from within page_cache_read() etc. The
weaker allocation mode might cause problems.



\
 
 \ /
  Last update: 2015-06-02 23:01    [W:0.071 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site