Messages in this thread | | | Date | Tue, 2 Jun 2015 21:28:17 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH] power_supply: bq25890: make chip_id int |
| |
Hi Laurentiu,
On Tue, Jun 02, 2015 at 01:36:51PM +0300, Laurentiu Palcu wrote: > Smatch static checker correctly detected an impossible condition because > chip_id was declared as u8, instead of int: > > drivers/power/bq25890_charger.c:843 bq25890_probe() > warn: impossible condition '(bq->chip_id < 0) => (0-255 < 0)' > > Also, while at it, fix the return value too.
Thanks, queued for 4.2.
-- Sebastian [unhandled content-type:application/pgp-signature] | |