lkml.org 
[lkml]   [2015]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 4/7] timer: Replace timer base by a cpu index
On Wed, 27 May 2015, Peter Zijlstra wrote:

> On Wed, May 27, 2015 at 02:52:36PM +0530, Viresh Kumar wrote:
> > > + timer->flags = (timer->flags & ~TIMER_BASEMASK) | cpu;
> >
> > Because 'cpu' is used only once in this routine, maybe we can use
> > 'new_base->cpu' here and the line will still be exactly 80 columns
> > long.
> >
> > Not sure, but maybe we can create a inline helper for this operation
> > as it is repeated at multiple places.
>
> I suggested bitfields at some point I think. That gets the compiler to
> generate those helpers for you.

I tried, but they are a PITA for the static initializiers and I could
not be bothered to deal with the endianess mess. Maybe I should try
again :)

Thanks,

tglx







\
 
 \ /
  Last update: 2015-06-02 16:21    [W:0.075 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site