Messages in this thread | | | Date | Tue, 2 Jun 2015 15:45:01 +0200 | Subject | Re: [PATCH v2 4/6] gpio: brcmstb: Allow GPIOs to be wakeup sources | From | Linus Walleij <> |
| |
On Fri, May 29, 2015 at 4:14 AM, Gregory Fong <gregory.0xf0@gmail.com> wrote:
> Several drivers (e.g. gpio-keys) allow for GPIOs to be configured as > wakeup sources, and this GPIO controller supports that through a > separate interrupt path. > > The de-facto standard DT property "wakeup-source" is checked, since > that indicates whether the GPIO controller hardware can wake. Uses > the IRQCHIP_MASK_ON_SUSPEND irq_chip flag because UPG GIO doesn't have > any of its own wakeup source configuration. > > Signed-off-by: Gregory Fong <gregory.0xf0@gmail.com>
(...) > + if (enable) > + enable_irq_wake(priv->parent_wake_irq); > + else > + disable_irq_wake(priv->parent_wake_irq); > + return 0;
No error handling? If the code assumes these calls will always succeed, atleast write that in a comment.
Yours, Linus Walleij
| |