Messages in this thread | | | Date | Tue, 2 Jun 2015 14:56:23 +0200 | Subject | Re: [PATCH] pinctrl: add pinctrl_register_reason() to return proper error code | From | Linus Walleij <> |
| |
On Fri, May 29, 2015 at 1:30 PM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> The pinctrl_register() just returns NULL on error, so the callers > can not know the exact reason of the failure. > > Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some > -ENOMEM on error of pinctrl_register() , although the error code > might be different from the actual cause of the error. > > This new function, pinctrl_register_reason(), helps the drivers get > and return the appropriate error code. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Suggested-by: Arnd Bergmann <arnd@arndb.de>
It should be named pinctrl_register_strict() or something. "reason" is anyways wrong, should be "cause", but please use _strict().
> If this patch is accepted, I can send a series to replace > the pinctrl_register() in each driver with pinctrl_register_reason().
If it is replaced *everywhere* there is no point in keeping a separate function. Then you should just do a big patch changing all usage sites and the original function.
Yours, Linus Walleij
| |