Messages in this thread | | | Date | Tue, 2 Jun 2015 13:35:42 +0200 | From | Ingo Molnar <> | Subject | Re: [RFC][PATCH] x86: Cleanup Kconfig |
| |
* Peter Zijlstra <peterz@infradead.org> wrote:
> > While looking at arch/x86/Kconfig I noticed a lot of if X86_{32,64} > clauses in the X86 symbol. Its much simpler to simply but these selects > in the right symbol and do away with the conditionals. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > --- > arch/x86/Kconfig | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 8fec04407245..a259db4cfe8c 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -11,6 +11,12 @@ config X86_32 > depends on !64BIT > select CLKSRC_I8253 > select HAVE_UID16 > + select HAVE_AOUT > + select HAVE_GENERIC_DMA_COHERENT > + select ARCH_WANT_IPC_PARSE_VERSION > + select MODULES_USE_ELF_REL > + select CLONE_BACKWARDS > + select OLD_SIGACTION
So I'd rather do it the other way around: move the remaining selects from X86_32 and X86_64 to the X86 section, and maybe group them by bitness.
The advantage: accidental duplication is more obviously wrong and a single feature's bitness-presence is obvious at a glance.
Thanks,
Ingo
| |