Messages in this thread | | | Date | Thu, 18 Jun 2015 09:40:10 +0200 | From | Ingo Molnar <> | Subject | Re: [GIT PULL 0/8] perf/core improvements and fixes |
| |
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo, > > Please consider pulling, this is on top of perf-core-for-mingo, that is > still outstanding, > > Thanks! > > - Arnaldo > > The following changes since commit b031220d520238075bd99513a420e65cf37866ad: > > perf probe: Fix to return error if no probe is added (2015-06-16 11:39:51 -0300) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2 > > for you to fetch changes up to 5d484f99aed547e235f2229653c95392a1bc3692: > > perf top: Allow disabling/enabling events dynamicly (2015-06-17 16:50:52 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes: > > User visible: > > - Allow disabling/enabling events dynamicly in 'perf top': > a 'perf top' session can instantly become a 'perf report' > one, i.e. going from dynamic analysis to a static one, > returning to a dynamic one is possible, to toogle the > modes, just press CTRL+z. (Arnaldo Carvalho de Melo)
Nice!! :-)
Btw., it would be nice if the status line carried information about whether collection is 'frozen' or running, at a glance. A hint might also suggest how to unfreeze the session - in case someone pressed Ctrl-Z to suspend the perf top session ...
Also, there's now a GUI inconsistency with perf report: which will now exit on Ctrl-Z. It should probably print a warning in the status line instead, that freezing/unfreezing only works in 'perf top'.
> > - Greatly speed up 'perf probe --list' by caching debuginfo > (Masami Hiramatsu) > > - Fix 'perf trace' race condition at the end of started > workloads (Sukadev Bhattiprolu) > > - Fix a problem when opening old perf.data with different > byte order (Wang Nan) > > Infrastructure: > > - Ignore .config-detected in .gitignore (Wang Nan) > > - Move libtraceevent dynamic list to separated LDFLAGS > variable (Wang Nan) > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (2): > perf evlist: Add toggle_enable() method > perf top: Allow disabling/enabling events dynamicly > > Masami Hiramatsu (2): > perf probe: Show usage even if the last event is skipped > perf probe: Speed up perf probe --list by caching debuginfo > > Sukadev Bhattiprolu (1): > perf trace: Fix race condition at the end of started workloads > > Wang Nan (3): > perf tools: Ignore .config-detected in .gitignore > perf tools: Fix a problem when opening old perf.data with different byte order > perf tools: Move libtraceevent dynamic list to separated LDFLAGS variable > > tools/perf/.gitignore | 1 + > tools/perf/Makefile.perf | 8 ++-- > tools/perf/builtin-top.c | 52 ++++++++++++++++++-------- > tools/perf/ui/browsers/hists.c | 2 + > tools/perf/util/evlist.c | 18 ++++++++- > tools/perf/util/evlist.h | 2 + > tools/perf/util/probe-event.c | 83 +++++++++++++++++++++++++++++++----------- > tools/perf/util/session.c | 50 ++++++++++++++++++------- > 8 files changed, 160 insertions(+), 56 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
| |