Messages in this thread | | | Subject | Re: [Patch v2] driver/i2c/mux: Add register based mux i2c-mux-reg | From | Alexander Sverdlin <> | Date | Thu, 18 Jun 2015 14:35:43 +0200 |
| |
Hello!
On 17/06/15 23:13, ext York Sun wrote: > + switch (mux->data.reg_size) { > + case 4: > + iowrite32(mux->data.values[chan], mux->data.reg); > + break; > + case 2: > + iowrite16(mux->data.values[chan], mux->data.reg); > + break; > + case 1: > + iowrite8(mux->data.values[chan], mux->data.reg); > + break;
I'd like to see at least [optional] read-back operation after each write. And if you stick with iowrite*(), maybe it desires a comment (in the Documentation/ file?), that write will be little-Endian, therefore BE users must take care...
Other than that it looks good to me...
-- Best regards, Alexander Sverdlin.
| |