lkml.org 
[lkml]   [2015]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] tun, macvtap: higher order allocations for skbs
On Thu, Jun 18, 2015 at 12:54:44PM +0200, Christian Borntraeger wrote:
> Am 18.06.2015 um 12:20 schrieb Michael S. Tsirkin:
> > Needs more testing. Anyone see anything wrong with this?
> Can you explain the motivation?
> FWIW, basic networking between two guest over macvtap still
> seems to work on s390 so I dont see any obvious regression.
>
> Christian

Shorter fragment list often makes processing in the net stack more
efficient.

> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > drivers/net/macvtap.c | 2 +-
> > drivers/net/tun.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
> > index 928f3f4..80e87e4 100644
> > --- a/drivers/net/macvtap.c
> > +++ b/drivers/net/macvtap.c
> > @@ -610,7 +610,7 @@ static inline struct sk_buff *macvtap_alloc_skb(struct sock *sk, size_t prepad,
> > linear = len;
> >
> > skb = sock_alloc_send_pskb(sk, prepad + linear, len - linear, noblock,
> > - err, 0);
> > + err, 1);
> > if (!skb)
> > return NULL;
> >
> > diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> > index cb376b2d..8f2f1e5 100644
> > --- a/drivers/net/tun.c
> > +++ b/drivers/net/tun.c
> > @@ -1069,7 +1069,7 @@ static struct sk_buff *tun_alloc_skb(struct tun_file *tfile,
> > linear = len;
> >
> > skb = sock_alloc_send_pskb(sk, prepad + linear, len - linear, noblock,
> > - &err, 0);
> > + &err, 1);
> > if (!skb)
> > return ERR_PTR(err);
> >


\
 
 \ /
  Last update: 2015-06-18 13:41    [W:1.119 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site