lkml.org 
[lkml]   [2015]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13.y-ckt 057/122] mnt: Fix fs_fully_visible to verify the root directory is visible
    Date
    3.13.11-ckt22 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Eric W. Biederman" <ebiederm@xmission.com>

    commit 7e96c1b0e0f495c5a7450dc4aa7c9a24ba4305bd upstream.

    This fixes a dumb bug in fs_fully_visible that allows proc or sys to
    be mounted if there is a bind mount of part of /proc/ or /sys/ visible.

    Reported-by: Eric Windisch <ewindisch@docker.com>
    Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    fs/namespace.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/fs/namespace.c b/fs/namespace.c
    index 01296f9..958e94a 100644
    --- a/fs/namespace.c
    +++ b/fs/namespace.c
    @@ -3005,6 +3005,12 @@ bool fs_fully_visible(struct file_system_type *type)
    if (mnt->mnt.mnt_sb->s_type != type)
    continue;

    + /* This mount is not fully visible if it's root directory
    + * is not the root directory of the filesystem.
    + */
    + if (mnt->mnt.mnt_root != mnt->mnt.mnt_sb->s_root)
    + continue;
    +
    /* This mount is not fully visible if there are any child mounts
    * that cover anything except for empty directories.
    */
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-06-18 01:21    [W:3.323 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site