lkml.org 
[lkml]   [2015]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13.y-ckt 063/122] thermal: step_wise: Revert optimization
    Date
    3.13.11-ckt22 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jean Delvare <jdelvare@suse.de>

    Commit 178c2490b99f898efc06d1ad75cadc84f13021a6 ("thermal: step_wise:
    cdev only needs update on a new target state") broke driver acerhdf.
    That driver abused the step_wise thermal governor until the bang_bang
    governor was available, and the optimization broke this usage model.

    Kernels v3.12 to v3.18 are affected. In v3.19 the acerhdf driver was
    switched to the bang_bang governor and that solved the problem.

    For kernels v3.12 to v3.17, the bang_bang governor isn't available
    yet so the easiest fix is to revert the optimization.

    Signed-off-by: Jean Delvare <jdelvare@suse.de>
    Reported-by: Dieter Jurzitza (https://bugzilla.opensuse.org/show_bug.cgi?id=925961)
    Tested-by: Peter Feuerer <peter@piie.net>
    Tested-by: Dieter Jurzitza
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/thermal/step_wise.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c
    index d89e781..769bfa3 100644
    --- a/drivers/thermal/step_wise.c
    +++ b/drivers/thermal/step_wise.c
    @@ -140,9 +140,6 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
    old_target = instance->target;
    instance->target = get_target_state(instance, trend, throttle);

    - if (old_target == instance->target)
    - continue;
    -
    /* Activate a passive thermal instance */
    if (old_target == THERMAL_NO_TARGET &&
    instance->target != THERMAL_NO_TARGET)
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-06-18 01:01    [W:4.035 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site