lkml.org 
[lkml]   [2015]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13.y-ckt 003/122] staging, rtl8192e, LLVMLinux: Change extern inline to static inline
    Date
    3.13.11-ckt22 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Behan Webster <behanw@converseincode.com>

    commit 6d91857d4826b382b3fd4fad95f52713be646f96 upstream.

    With compilers which follow the C99 standard (like modern versions of gcc and
    clang), "extern inline" does the opposite thing from older versions of gcc
    (emits code for an externally linkable version of the inline function).

    "static inline" does the intended behavior in all cases instead.

    Signed-off-by: Behan Webster <behanw@converseincode.com>
    Suggested-by: Arnd Bergmann <arnd@arndb.de>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/staging/rtl8192e/rtllib.h | 4 ++--
    drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
    2 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
    index 05ef49f..daa2ce7 100644
    --- a/drivers/staging/rtl8192e/rtllib.h
    +++ b/drivers/staging/rtl8192e/rtllib.h
    @@ -2943,12 +2943,12 @@ void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, u8 is_mesh);

    extern const long rtllib_wlan_frequencies[];

    -extern inline void rtllib_increment_scans(struct rtllib_device *ieee)
    +static inline void rtllib_increment_scans(struct rtllib_device *ieee)
    {
    ieee->scans++;
    }

    -extern inline int rtllib_get_scans(struct rtllib_device *ieee)
    +static inline int rtllib_get_scans(struct rtllib_device *ieee)
    {
    return ieee->scans;
    }
    diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
    index 933bd6d..7933f9f 100644
    --- a/drivers/staging/rtl8192e/rtllib_softmac.c
    +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
    @@ -341,7 +341,7 @@ inline void softmac_ps_mgmt_xmit(struct sk_buff *skb,
    }
    }

    -inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee)
    +static inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee)
    {
    unsigned int len, rate_len;
    u8 *tag;
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-06-18 00:41    [W:4.061 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site