lkml.org 
[lkml]   [2015]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 1/2] perf,tools: add time out to force stop proc map processing
On 6/17/15 1:56 AM, kan.liang@intel.com wrote:
> diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> index 793b150..ac6cf2a 100644
> --- a/tools/perf/util/event.c
> +++ b/tools/perf/util/event.c
> @@ -213,6 +213,8 @@ static int perf_event__synthesize_fork(struct perf_tool *tool,
> return 0;
> }
>
> +#define MMAP_TIMEOUT (50 * 1000000ULL)
> +

How did you determine 50msec is a good time? This seems really low to me
considering the range of platforms supported by perf and various run
time conditions. The default needs to work right on all platforms.

Why not have the default be infinity and users who need the feature use
the option provided in patch 2?

David


\
 
 \ /
  Last update: 2015-06-17 18:21    [W:0.144 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site