Messages in this thread | | | Subject | Re: [PATCH 2/6] mtd: nandsim: Fix kasprintf() usage | From | Joe Perches <> | Date | Tue, 16 Jun 2015 21:42:41 -0700 |
| |
On Tue, 2015-06-16 at 19:07 -0700, Brian Norris wrote: > On Mon, Jun 01, 2015 at 11:10:50PM +0200, Richard Weinberger wrote: > > kasprintf() used in get_partition_name() does a dynamic > > memory allocation and can fail. We have to handle that case. [] > > diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c [] > > @@ -743,6 +743,11 @@ static int init_nandsim(struct mtd_info *mtd) > > goto error; > > } > > ns->partitions[i].name = get_partition_name(i); > > + if (!ns->partitions[i].name) { > > + NS_ERR("unable to allocate memory.\n"); > > Probably don't really need the allocation failure messages. But this > matches the current style, so we can just rip the messages out at > another time.
Maybe that other time can use the more typical pr_<level> mechanisms instead of NS_<LEVEL> too.
As far as I can tell, the only thing that the NS_<LEVEL> macros do is prefix "error: " and "warning: " to the output.
"[nandsim] " could be added via pr_fmt and it could be changed to "nandsim: " for commonality with the majority of the kernel logging.
| |