lkml.org 
[lkml]   [2015]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: wilc1000: remove WILC_WFIDrvHandle
On Wed, Jun 17, 2015 at 06:46:20PM +0530, Sudip Mukherjee wrote:
> WILC_WFIDrvHandle was:
>
> typedef struct {
> s32 s32Dummy;
> } *WILC_WFIDrvHandle;
>
> which basically meant a pointer to an integer.
> so removed the typedef and replaced all WILC_WFIDrvHandle with int *
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>
> replacement was done by using sed, just manually removed the typedef.
> build ok, before this change total 77 build warning, after this patch
> same number of warnings.

Which means this is not the correct fix for this :)

The driver is obviously broken for 64bit systems, and these warnings are
showing that, let's fix this "correctly" please.

sorry, I'm not going to take this patch.

greg k-h


\
 
 \ /
  Last update: 2015-06-17 16:21    [W:0.022 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site